Skip to content

Add Events Header to StackLayout #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Events Header to StackLayout #213

wants to merge 1 commit into from

Conversation

AngeloAnolin
Copy link

Some events or methods need to be defined for the control as some of them are not documented in the api reference (https://docs.nativescript.org/api-reference/classes/_ui_layouts_stack_layout_.stacklayout). This will help developers know what events are available for this control where they could wire up some code.

Some events or methods need to be defined for the control as some of them are not documented in the api reference (https://docs.nativescript.org/api-reference/classes/_ui_layouts_stack_layout_.stacklayout). This will help developers know what events are available for this control where they could wire up some code.
@nativescript-vue-bot
Copy link

Deploy preview for nativescript-vue ready!

Built with commit d8540dd

https://deploy-preview-213--nativescript-vue.netlify.com

@rigor789
Copy link
Member

Hi @AngeloAnolin, thanks for the PR!

The reason we are not listing all the events is because there are many that are inherited from ViewBase/View. I would rather include information about event inheritance, and how to look for them than to list all possible events like doubleTap, longPress, swipe, pan, pinch, loaded, and more... and then add them to every element in the docs - which I don't think is a good idea.

I will keep this open as a reminder to add more information about the even inheritance, but I will not be merging it.

## Events
| Name | Description |
|------|-------------|
`tap` | Emitted when the layout is tapped.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`tap` | Emitted when the layout is tapped.
| `tap` | Emitted when the layout is tapped. |

@ikoevska
Copy link
Contributor

ikoevska commented Nov 5, 2018

Hi @AngeloAnolin, thanks for the PR!

The reason we are not listing all the events is because there are many that are inherited from ViewBase/View. I would rather include information about event inheritance, and how to look for them than to list all possible events like doubleTap, longPress, swipe, pan, pinch, loaded, and more... and then add them to every element in the docs - which I don't think is a good idea.

I will keep this open as a reminder to add more information about the even inheritance, but I will not be merging it.

@rigor789 it might make more sense to create an issue about adding event inheritance docs? This will let us close this one.

@rigor789
Copy link
Member

rigor789 commented Nov 5, 2018

@ikoevska yes! Opened #233

@rigor789 rigor789 closed this Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants